Commit b5f26a02 authored by Srinivasan Muralidharan's avatar Srinivasan Muralidharan
Browse files

[FAB-5150] remove bin data from install error



Authorization error contains bin data (package) which is useless
for error reporting and would get in the way of SDKs and other
tools's reporting. This CR removes the bin data. Further we don't
want to peek into the data on auth. failure and so will _not_
attempt to read the package to enhance the reported error.

. patch 2 fixed lscc unit test to look for right error string

Change-Id: Ic55eba8d890aa2489488fdbd54d4ccc3a8483fed
Signed-off-by: default avatarSrinivasan Muralidharan <muralisr@us.ibm.com>
parent bdd4a96f
......@@ -721,7 +721,7 @@ func (lscc *LifeCycleSysCC) Invoke(stub shim.ChaincodeStubInterface) pb.Response
// 2. check local MSP Admins policy
if err = lscc.policyChecker.CheckPolicyNoChannel(mgmt.Admins, sp); err != nil {
return shim.Error(fmt.Sprintf("Authorization for INSTALL on %s has been denied with error %s", args[1], err))
return shim.Error(fmt.Sprintf("Authorization for INSTALL has been denied (error-%s)", err))
}
depSpec := args[1]
......
......@@ -86,7 +86,7 @@ func TestInstall(t *testing.T) {
testInstall(t, "example02.go", "0", path, InvalidChaincodeNameErr("example02.go").Error(), "Alice")
testInstall(t, "", "0", path, EmptyChaincodeNameErr("").Error(), "Alice")
testInstall(t, "example02", "1{}0", path, InvalidVersionErr("1{}0").Error(), "Alice")
testInstall(t, "example02", "0", path, "Authorization for INSTALL on", "Bob")
testInstall(t, "example02", "0", path, "Authorization for INSTALL has been denied", "Bob")
}
func testInstall(t *testing.T, ccname string, version string, path string, expectedErrorMsg string, caller string) {
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment