The TODO was recently addressed. Cleaning up the TODO here.

Change-Id: I0cd9c5feedc847a73296c7e46a7a5ac2b0d1e468
Signed-off-by: denyeart <enyeart@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2142



The new configuration structure needs to be comparable in order to
validate which portions of the incoming configuration have changed.
This CR adds a set of utilities to do just that.

Change-Id: I061288145e7d4ae257568043d152c087f1796957
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2195



Refactoring the MSP config handler code it made sense to embed the MSP
manager into the config handler structure.  This results in an infinite
loop which this CR addresses.

Change-Id: I78e7d9e5079e954f4ed891a659bb0c3c94d620d7
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2194



Look for pb.Response only on pb.ChaincodeMessage_COMPLETED. Others are
non-CC errors and will not carry response from chaincode.

Change-Id: I24160a643dd09089f0e2f5cf694e620cde29b0fc
Signed-off-by: Srinivasan Muralidharan <muralisr@us.ibm.com>

Peers in the same organization might need to
communicate by connecting to endpoints that are only route-able
from within the organization, and when communication with peers
in different organizations, they should connect to endpoints
that are route-able from outside the organization.

For example if the peers are behind a NAT with port-forwarding rules
for the peers.

This commit adds an internal endpoint to the Member proto message.
The endpoint is signed separately and when a message would cross
an organization, the inner endpoint would be deleted from the last
peer that was in the source organization.

The access control and filtering will be done in upcoming commits.
This commit only adds the internal endpoint, and changes the gossip
logic to prefer using the internal endpoint over the external one.

Unit tests: I changed the discovery and gossip unit tests accordingly,
and added a check in the discovery unit test that both endpoints are
gossiped to peers.
In the gossip unit-tests, made sure that the external endpoint is
never used, and only the internal one is used.
In upcoming commits, I would add tests that have several organizations.

How was this tested?
This commit doesn't add any new functionality, so I just tested
that the communication and discovery between peers wasn't damaged.

I ran a modified docs/channel-setup.md with an additional peer (peer1)
- Once with CORE_PEER_GOSSIP_BOOTSTRAP=ip-of-peer-0:7051
  and saw that peers were able to connect to one another

- Once without any bootstrap set, but created an anchor peer file
  with the ip address of peer0,
  and made peer0 and peer1 join the channel and saw in the logs
  that channel-based messages were sent between the peers.
Signed-off-by: Yacov Manevich <yacovm@il.ibm.com>
Change-Id: I243b55fc192c3d7e516598a899cd58039ded7587

This change-set modifies msp to use intermediate CAs to validate
certificates.

Change-Id: I3d0a5888af78085686eba01704369800857625a2
Signed-off-by: Alessandro Sorniotti <ale.linux@sopit.net>

In order to control access, all queries will need to go through
application chaincode. This change is in response to early
v1 feedback.

See marbles02 for an example of calling GetQueryResult from application chaincode.

In the future if there is capability to place ACL on peer APIs,
then it would be possible to expose GetQueryResult as a peer
API (or via QSCC).

Change-Id: I1613563caf823e45fdfebeaa133f4ec523716cec
Signed-off-by: denyeart <enyeart@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2108



This CR adds the config schema for the channel configuration (which
references the application and orderer config schemas).

Change-Id: Id75939622e826af0ce4187d59f9b8ba4d16eb7d1
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2106



This CR defines the acceptable configuration structure for the orderer
pieces of the configtx.

Change-Id: I09bbf9fd3e37d3d8343cf56e8e88a2e8545f0cb7
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2107



Initial pass defining the structures which are currently populated into
the application config.

Change-Id: Ica72acd4ac95a7821f077e0e222b79fd5685d396
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2105



Because the new configtx format is so much more flexible than the
original, we need to make sure that it is locked down to keep people
from going crazy with it. The restrictions can be relaxed as the use
cases are made, but initially the goal is to restrict the configuration
to a minimal set and loosen from there.

To do this, protos for a simple schema should be defined so that the
configtx manager can enforce the restrictive configuration scheme.

Change-Id: Iff0df7910aa216a03267beeb86b5b9f3f29d4b70
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2130



Now that the assorted configtx Handlers have been consolidated, the
piecemeal instantiation across peer/orderer is no longer necessary and
all components can be instantiated together.  This is needed in
preparation of the pending configtx overhaul.

Change-Id: Ie3a607d38cbaea75cd6497666a12ed6664c52af2
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2126



The other handlers have been moved from their component pieces to reside
within configtx/handlers in preparation of the impending configuration
overhaul, this does the same for the last remaining handler (MSP).

Change-Id: Idec422b2402fab6b5e036b1a5cdabfc2fc88ad72
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2104



The orderer and application shared config have just been moved under
common/configtx.  The channel configuration should be normalized to this
pattern and location as well.

Change-Id: I3cda8b73a4c94ff528db6e5cdbc987b4c69f90f8
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2033



The user facing documentation refers to channels, but the vast majority
of the fabric code refers to chains.  This CR switches the protos to
refer to channels as they are generally the interface between the user
and fabric code.

Change-Id: I869e6d68c1228e638a99e2460274889f18f2543d
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2030

According to the proto style guide, fields should be lower_underscored
which generally converts nicely to golang as LowerUnderscored.  However,
for certain cases, like chaincode_id, this converts to ChaincodeId
rather than as desired to ChaincodeID.  This change updates the
problematic fields to use the correct proto style, and updates the
golang to expect the appropriate (although odd) output.

Note, per the proto devs, https://github.com/golang/protobuf/issues/53
there is no intent to modify the protoc generation to attempt to produce
upper case ID API, etc.

Still, the odd golang results seem worth following the style guide.

Note, this CR also changes chainID to channel_id as these lines were
already being affected and a community apparently came to a decision
that the world channel is preferable to the word chain.

https://jira.hyperledger.org/browse/FAB-2033



Change-Id: I9c5ebab88fc8d7f45335c904a56676c55a467e5d
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2029



Per the official proto style guide, enums should be UPPER_CASE but the
current code has a mixture of UPPER_CASE and CamelCase.  This is
internal inconsistency is a problem, and this CR fixes the fabric protos
to adhere to the official proto style.

Change-Id: I95af90f29f9e8fa8a6eecbb528516cccc3187979
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2166



We were defaulting to "0" if a version was not provided. Should
have removed the default when the new model moved from WIP.

Force version to be provided by checking for empty version in LCCC.

CLI enforces as well.

Change-Id: I93922bc37e48555c377c44243adf46ea522b75f1
Signed-off-by: Srinivasan Muralidharan <muralisr@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-1783



peer install needs samples in peer. Mount examples on the peer
as well.

Change-Id: I6dc0a4895dd11c7b87b75b2cb91269deb9839052
Signed-off-by: Srinivasan Muralidharan <muralisr@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2027

Per https://jira.hyperledger.org/browse/FAB-2026

 the proto style in
fabric is inconsistent and violates accepted proto style guidelines.

This CR makes the non-golang code invasive proto changes to conform with
the style guide.

In particular, protoc converts lower_underscore_separated to
LowerUnderscoreSeparated which means that most of our existing fields
can be normalized to the official proto style with no code changes.

This does not fix fields which contained upper case abbreviations
particularly fields ending in 'ID' like txID which must become tx_id and
will be translated to TxId.

This does not fix the enum fields which by proto style should be
UPPER_CASE as this will also require code changes.

Change-Id: Id32d6caba43be9e1c6b1f638be284071bf52f0fd
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>