1. 28 Mar, 2019 10 commits
    • manish's avatar
      FAB-14865 - Fix log message · 0d738341
      manish authored
      
      
      This CR fixes a log message such that it prints the
      height in readable form as opposed to in hex.
      
      Not closing this Jira for now - as we can use this to
      fix the similar issue elsewhere as well
      
      Change-Id: Id4b79cc280605a23bc00589497b4f0120a72d99a
      Signed-off-by: default avatarmanish <manish.sethi@gmail.com>
      0d738341
    • yacovm's avatar
      [FAB-14863] Fix flake in TestBlockingSend · be8ae4c1
      yacovm authored
      
      
      The test expected the goroutine that picks a message
      from a channel and invokes Send() to not fire fast enough
      and then it would overflow.
      
      This test, makes this deterministic by:
      
      1) Ensuring the goroutine actually picks the message from
         the channel and is stuck on the fake gRPC stream.
      2) Moves the assertion of the overflow to after sending
         a third message, so that now it overflows for sure.
      
      Ran it 100 times and it doesn't fail now.
      
      Change-Id: Ica9dac316f5333c0cd24dffcc1f7b1f30aa67f45
      Signed-off-by: default avataryacovm <yacovm@il.ibm.com>
      be8ae4c1
    • yacovm's avatar
      [FAB-14858] Address flake in TestSendBigMessage · 193d8844
      yacovm authored
      
      
      This change set addresses a flake in TestSendBigMessage that happens
      due to creating the stream too early and freezing too late.
      
      Now the code first freezes, and only then creates the stream.
      
      Also switched the waitGroup to a condition variable which is more
      idiomatic for this use case.
      
      Change-Id: I673e8d6cc38caf68fd298dc1a3acfc0af1302961
      Signed-off-by: default avataryacovm <yacovm@il.ibm.com>
      193d8844
    • yacovm's avatar
      [FAB-14852] Validate TLS certs are x509 encoded · da4ddd05
      yacovm authored
      
      
      This change set adds validation that the TLS certificates
      in a config update are x509 certificates.
      
      Change-Id: Id68202ff1ae47970d76e8435f271329da7ebfaec
      Signed-off-by: default avataryacovm <yacovm@il.ibm.com>
      da4ddd05
    • Jay Guo's avatar
      FAB-14840 check Raft config for HeaderType_CONFIG · f9975970
      Jay Guo authored
      
      
      Raft config metadata checks, e.g. non-zero TickInterval, should also
      be done against HeaderType_CONFIG transactions.
      
      Also, since we check against nil consenter set, this also prevents
      user from removing node from single node cluster, which results in
      dead channel.
      
      Change-Id: Idf0967ed19ffed964f16c83a9862c1c59e132686
      Signed-off-by: default avatarJay Guo <guojiannan1101@gmail.com>
      f9975970
    • Jay Guo's avatar
      FAB-14821 validate Raft config metadata · 7d06d382
      Jay Guo authored
      
      
      While creating new channel, the Raft config metadata supplied
      should be validated before being proposed and consented, to
      avoid crashing the orderer due to malformed configs.
      
      Change-Id: Ie7cbd9ff609c1cb04e891dd05d49fa8a80195c98
      Signed-off-by: default avatarJay Guo <guojiannan1101@gmail.com>
      7d06d382
    • Jay Guo's avatar
      FAB-14822 change func signature of CreateChannelFail · 65061e71
      Jay Guo authored
      
      
      Change the func signature of nwo.CreateChannelFail to be
      equal to nwo.CreateChannel so it can be reused.
      
      Change-Id: Icbcdd38162fa04236b79201c7be62892bafd86d7
      Signed-off-by: default avatarJay Guo <guojiannan1101@gmail.com>
      65061e71
    • Jay Guo's avatar
      FAB-14766 improve logs text for serviceability · 70b88048
      Jay Guo authored
      
      
      - block %d -> block [%d]
      - remove [channel: %s] from error body, because normally caller
        would decorate it before logging, and we sometimes end up with
        ERRO: [channel: mychannel] there's an error: [channel: mychannel] foo
      
      Change-Id: I6cba4a34bb326d17a5439dd10909edd5f799e0e4
      Signed-off-by: default avatarJay Guo <guojiannan1101@gmail.com>
      70b88048
    • Jay Guo's avatar
      FAB-14745 more harsh snapshot integration test · d87e72c0
      Jay Guo authored
      
      
      This CR alter the snapshot integration test to cover the case
      where even lagged node can still help forming a minimum quorum
      and start catching up with snapshot.
      
      Change-Id: I97f91c311938c35a6a287237f48146020c799496
      Signed-off-by: default avatarJay Guo <guojiannan1101@gmail.com>
      d87e72c0
    • Jay Guo's avatar
      FAB-14764 halt with delay if it's removed as leader · c4432943
      Jay Guo authored
      
      
      If leader halts too quickly, followers might not be able to pick up
      the config change soon enough. This CR introduces a delay before
      halting the chain on leader.
      
      Change-Id: I384c06001bf31b2816d463e06bf6199a77a64f25
      Signed-off-by: default avatarJay Guo <guojiannan1101@gmail.com>
      c4432943
  2. 27 Mar, 2019 22 commits
  3. 26 Mar, 2019 3 commits
  4. 25 Mar, 2019 2 commits
  5. 24 Mar, 2019 3 commits