In the current code, before adding a block to the ledger,
ledger verifies the correct sequence number of the block
just to double check that gossip is delivering the right
sequence of blocks. In addition, before block is delivered
to ledger, the signatures of the ordering service node(s)
are verified that fulfills the requirement of the trust model.

Though the above checks are sufficient for keeping an unintended
block from getting committed to ledger. Still, it may not be a
bad idea to add an additional check that verifies that the field
`block.Header.PreviousHash` present in the block matches with
the hash of the last committed block.

This check is a simple bytes comparison and hence does not
cause any observable performance penalty and may help in
detecting a rare scenario if there is any bug in the
ordering service.

FAB-12033 #done

Change-Id: I8d42bc4969d390a2c0f3aad0f7ff884f273c2ba9
Signed-off-by: manish <manish.sethi@gmail.com>

Fix code as per comments posted in
https://gerrit.hyperledger.org/r/c/26332/



FAB-12024 #done

Change-Id: Ia83be34035393410b8c79967d0e783067a9d43ed
Signed-off-by: senthil <cendhu@gmail.com>

Change-Id: I821e6f09c2ee251de5e92fa90d95bc8706e0ced8
Signed-off-by: ping40 <norberthu30@gmail.com>

Added flag to enable/disable missing data reconciliation.
When disabled, no missing data entries are stored in the pvtstore.

FAB-12019 #done

Change-Id: Ifaf980942f92a57a3f4d23024846956951e84124
Signed-off-by: senthil <cendhu@gmail.com>

Add a flag to indicate whenever pvt data reconciliation has to be
enabled or disabled. Defaulting to be disabled for 1.3, while later on
we need to expose this key into configuration and default to true.

Change-Id: Ic5492433110d97dd9687a59e0d75dfa82a1ba424
Signed-off-by: Artem Barger <bartem@il.ibm.com>

Initial CR merged. Addressing additional
comments.

Change-Id: I69482a6c0613b68cbfa034be1bce34de84172bd2
Signed-off-by: joe-alewine <Joe.Alewine@ibm.com>
Signed-off-by: David Enyeart <enyeart@us.ibm.com>

historydb code assumes that the keys does not contain a nil byte.
In the presence of such keys, a historydb query can behave in an
unpredictable way that ranges from including the wrong results
to a panic crash.

The main issue is that when the keys have nil bytes, additional
keys fall in the results of the range query that is formed for
scanning the history of a key. This CR provides a simple fix
in which these non-relevant results will be skipped.

Though, ideally, the keys layout should be such that the non-relevant
results of a scan should be zero, however, that solution requires a
change in key formats and will require a rebuild of the historydb
and hence not suitable for an interim release and will potentially
be provided with 2.0 release.

done #FAB-11244

Change-Id: I843f1babc2673d3a38c47e9e04a660203180a3de
Signed-off-by: manish <manish.sethi@gmail.com>

Purge managment for private data state prefetches the information
about the data that is going to be expired in the next upcoming
block. This task is perfomed in a background goroutine. When the
ledger is closed, this task is not stopped and causes a nil pointer
panic inside goleveldb code.

This is a timing based issue and is observed in quite a few tines in
unit tests failures in CI. When the db.Close (issued by ledger close)
and db.NewIterator (issued by the background goroutine) functions are
invoked on goleveldb in parallel, this may happen that the Close function
makes the internal mem-buffers of goleveldb as nil followed by an access
to theses buffers by the function NewIterator.

As a fix, this CR makes the Close function to wait for the background
routine to finish.

FAB-11974 #done

Change-Id: I331476a6814ed2e6effcf10cc9310adb387722ff
Signed-off-by: manish <manish.sethi@gmail.com>

Currently the warning is only seen in peer logs if couchdb debug is enabled.

Peer should log a warning without having to enable couchdb debug.

Log warning to peer when "no matching index found" warning comes from
couchdb queries.

Change-Id: I46a5fa663c502bbdf74261a4925ce54633384d1f
Signed-off-by: Chris Elder <chris.elder@us.ibm.com>

Replace the CACertificateBundlePath field with a method that constructs
the path from the network root and `vipgq` doc for the new methods.

Change-Id: I2cd550019e7c301b318793f5b104bf6db5d77d49
Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>

This change documents pagination for rich query and range queries.

Changes will applied to couchdb_as_state_database.html and the couchdb
tutorial.

Change-Id: I7d85c04e55b71f4c76be178c012eea4a25bb17f9
Signed-off-by: Chris Elder <chris.elder@us.ibm.com>
Signed-off-by: joe-alewine <Joe.Alewine@ibm.com>
Signed-off-by: David Enyeart <enyeart@us.ibm.com>

Keys in a collection are hashed to binary and may contain unprintable
characters. This change set introduces hex encoding for said keys in order
to improve the usefulness of log entries.

Change-Id: I3bfcf63506cca968ca2d514c33bf5d20e4782e2a
Signed-off-by: Alessandro Sorniotti <ale.linux@sopit.net>
Signed-off-by: Matthias Neugschwandtner <eug@zurich.ibm.com>

Until now, when transactions arrive for a chaincode that is not running,
the first transaction causes the chaincode to launch while all others
are rejected until the chaincode launch has completed. This is
unfriendly and unexpected behavior.

With this change, when transactions arrive for chaincode that is
launching, the transactions will be queued until the launch process has
completed.

If the launch fails for some reason, all queued transactions will be
terminated with the error from the launch. If the initial launch times
out, all queued transactions (regardless of arrival) will be terminated
with the timeout error.

Change-Id: I12a9750b1a57e3e494cf4026539ea490dcf0573e
Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>

This change set makes integration tests run with TLS.

Change-Id: I917f512b3765e52ec27d17830e93e091b360f322
Signed-off-by: yacovm <yacovm@il.ibm.com>

Fix minor issues like the following.
- Incorrect indent
- Unnecessary double quotation

Change-Id: I93d6aee85a035f44367b85cf13c46ed2cdf38576
Signed-off-by: Jun Nemoto <jun.nemoto.ff@hitachi.com>

Test TestShutdown fails intermittently on ppc64le
leveraging Eventually() and thus retry.

Change-Id: I4a4870105cba616663f4d25404e0f3ab253db214
Signed-off-by: Krishna Harsha Voora <krishvoor@in.ibm.com>

This CR fixes a minor bug - an iterator need to be properly released.

Change-Id: Ic05429f4978067250fa30e1d5c304e744160d37e
Signed-off-by: ping40 <norberthu30@gmail.com>

see FAB-11973 for details

Change-Id: I5682c6ba2839fd6791c0e5cfd4663d4e068a361a
Signed-off-by: manish <manish.sethi@gmail.com>
Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>

Change-Id: I8b0724039dbdba20b68688445cc9cb3f2dfcfc44
Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>

Change-Id: I5107d00794faf1f41befaff9bb45f6ee3dbd668b
Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>

This adds information about testing to the
main fabric directory and links it from the
fabric README. This also has an image to
the Test Pyramid as a visual guide.

Change-Id: I5df40da3c90da3c880a97d56bde99c43c55f6560
Signed-off-by: Latitia M Haskins <latitia.haskins@gmail.com>