This patchset helps clean up the code and docs:

* Fix redundant parenthesese.
* Fix mismatching params in func return.
* Fix variable name collides with imported package name and builtin
  function or reserved words.
* Fix word typos.

Change-Id: I30304c233067ead7e74d18e3caf2604b3ed1490a
Signed-off-by: Baohua Yang <yangbaohua@gmail.com>

There is a missing check in the endorser code for a nil chaincodeID.
Added a test.

Change-Id: I10cb58ddb49cb9768aa2cdb9e9dc0b24808a5fbc
Signed-off-by: yacovm <yacovm@il.ibm.com>

The configtx code uses an 'append(...)' against a slice, and records the
new slice address when computing the config map.  Through sheer dumb
luck, this code works for config groups which are only nested 2 levels
deep, because the append call triggers a true new memory allocation.
However, for config groups 3 levels deep (such as consortium groups),
the append call actually re-uses the underlying memory for the slice.

This causes the path to be corrupted internally for the consortium group
items, and cause the wrong policy to be resolved when checking for a
policy which has been specified relatively.

This fix manually allocates new memory, copies it, and then appends the
element.

Change-Id: I0f4df619e006cdfebba60173156bda597d42a544
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

Update e2e scripts to to use kafka orderering service instead of solo

Change-Id: Id6ac848e870286c225de4251663badd9f94ebf2c
Signed-off-by: ratnakar <asara.ratnakar@gmail.com>

When the Enqueue method was removed in favor of the Order/Configure
methods, the existing Broadcast code continued to use them very much
like the old Enqueue method.

This CR removes the hack which allowed the Broadcast code to continue to
function and instead leverages the msgprocessor code to appropriately
route messages to either Order or Configure.

Because the filters were removed from the blockcutter, the only place
they are currently used is in the Broadcast path.  This injects an
unneeded dependency into the Broadcast framework, making tests more
difficult to mock, and generally complicating the code.

This CR removes the filtering from the Broadcast path, in favor of doing
the filtering entirely in the msgprocessor path.  This was at one point
split into two CRs around issue FAB-5268, but it turned out to be
infeasible to break this into two changes while not breaking the e2e.

Change-Id: I6ef3595f26a4e9dfdbf6dec636b434e725ccd6f2
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

The current consenter interface only allows for one sort of message
ingress.  All messages are received via 'Enqueue', and treated
identically.

In order for the consenter to be able to differentiate and handle config
vs non-config messages differently, the consenter needs two diferent
ingress points for messages.

This CR replaces the Enqueue method with two methods: Order and
Configure.

For the time being, these methods behave exactly as Enqueue, but will be
leveraged in future CRs.

Change-Id: I3701e5e3c0de4833a455c49acebbad70c6ed763c
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

The primary goal of the series in FAB-5258 is to prevent all OSNs from
having to validate all messages for all channels.  Since all messages
pass through the block cutter, the block cutter cannot be involved in
message validation as it currently is.

This CR pulls the message validation out of the blockcutter and pushes
it into the msgprocessor definitions.  Ultimately, the msgprocessor
interfaces will only be called if necessary, eliminating the performance
bottleneck.

Change-Id: I3c0d41e47873aa6e764c70fd176722306f00655c
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

Current implmenetaition makes use of discovery GetMembership API and
iterates over to construct the result, while this is redundant, since we
can return GetMembership result right away. This commit replace
iteration with simply returning result of discovery service.

Change-Id: Idd69acd08560e0fac84bae43cd8acd50e6d8bdd0
Signed-off-by: Artem Barger <bartem@il.ibm.com>

There is a map access that isn't protected by a lock
that was introduced in a recent commit.

Change-Id: I31f884f76aaf0ba4a6b547c66830d8cd652f3c4e
Signed-off-by: yacovm <yacovm@il.ibm.com>

With this change the documentation instructs Windows users
to work within the Docker Quickstart Terminal rather than
Git Bash which does not work for Windows 10.
This change also adds a note to the first curl command to
address the recurrent problem with Windows users reporting
failure due to using an outdated version of curl.

Patch-set #2: added a piece about installing npm grpc based
on users reporting this was necessary.

Change-Id: I95e7caeddc43e48f107955018aced112893ca540
Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>

This CR computes the hash of the Docker image name before replacing
any invalid characters in order to avoid the chance of any name
collisions due to replacement of invalid characters.

Change-Id: I164bb4236fcdba4c0d6dd369fb62f747309d353c
Signed-off-by: Will Lahti <wtlahti@us.ibm.com>

Rename a method in benchmark test to be more precise.
Also a typo in blockfile_mgr.go is fixed.

Change-Id: Iea289a71e4dfb987a39a850514bbfcac99dc4781
Signed-off-by: Jay Guo <guojiannan1101@gmail.com>

This fix appends a hash of the Docker image name to the image name
to ensure a chaincode with different capitalization does not override
the container of an already instantiated chaincode. This problem was
introduced by the need to convert all Docker image names to lowercase.
The Docker container name will retain its capitalization as that
restriction only applies to the image name.

Change-Id: I854f80b2f0e0269d9bbc60725f82b7e5a804b6fd
Signed-off-by: Will Lahti <wtlahti@us.ibm.com>

The multichannel (formerly multichain) package became a bit of a dumping
ground for all of the interface definitions used in the orderer system.
this makes the multichannel package clunky, difficult to mock, and
encourages poor separation between components.

This CR extracts the interface definitions and moves them to more
sensible locations based on the natural separation of function within
the orderer codebase.

It is also fixed the multichannel package to generally return pointers
to structs, rather than to interfaces, following the golang best
practice of accepting interfaces and returning structs.

Change-Id: Iaf004e1dadf7bf92d106bd7c90f244e0089b9924
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

Change-Id: I13af4e7452cac28d0708ab4ba996af05f3fc8614
Signed-off-by: Christopher Ferris <chrisfer@us.ibm.com>

Validator is sending peer.TxValidationCode_INVALID_OTHER_REASON instead of
peer.TxValidationCode_ENDORSEMENT_POLICY_FAILURE due to a wrong type check.

Added UT to cover the switch and ensure correct tx flag been assigned.

Change-Id: I7abe8828323780d527b24905f54d9a06e5f70b4e
Signed-off-by: Srinivasan Muralidharan <muralisr@us.ibm.com>
Signed-off-by: Artem Barger <bartem@il.ibm.com>

No matter what is provided as SANS in crypto-config.yaml, current code
logic of cryptogen takes them as host names, resulting in failed
communication if fabric network is configured with IP addresses.

The change proposes to examine the content of SANS, setting them as IP
SANs in the generated certificates if they are IP addresses.

Change-Id: Ie9cbc341ab21ec5966fdabcd48d79a9d05d7b961
Signed-off-by: Tony Yang <tony@arxanfintech.com>