https://jira.hyperledger.org/browse/FAB-2033



The user facing documentation refers to channels, but the vast majority
of the fabric code refers to chains.  This CR switches the protos to
refer to channels as they are generally the interface between the user
and fabric code.

Change-Id: I869e6d68c1228e638a99e2460274889f18f2543d
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2030

According to the proto style guide, fields should be lower_underscored
which generally converts nicely to golang as LowerUnderscored.  However,
for certain cases, like chaincode_id, this converts to ChaincodeId
rather than as desired to ChaincodeID.  This change updates the
problematic fields to use the correct proto style, and updates the
golang to expect the appropriate (although odd) output.

Note, per the proto devs, https://github.com/golang/protobuf/issues/53
there is no intent to modify the protoc generation to attempt to produce
upper case ID API, etc.

Still, the odd golang results seem worth following the style guide.

Note, this CR also changes chainID to channel_id as these lines were
already being affected and a community apparently came to a decision
that the world channel is preferable to the word chain.

https://jira.hyperledger.org/browse/FAB-2033



Change-Id: I9c5ebab88fc8d7f45335c904a56676c55a467e5d
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2029



Per the official proto style guide, enums should be UPPER_CASE but the
current code has a mixture of UPPER_CASE and CamelCase.  This is
internal inconsistency is a problem, and this CR fixes the fabric protos
to adhere to the official proto style.

Change-Id: I95af90f29f9e8fa8a6eecbb528516cccc3187979
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2166



We were defaulting to "0" if a version was not provided. Should
have removed the default when the new model moved from WIP.

Force version to be provided by checking for empty version in LCCC.

CLI enforces as well.

Change-Id: I93922bc37e48555c377c44243adf46ea522b75f1
Signed-off-by: Srinivasan Muralidharan <muralisr@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-1783



peer install needs samples in peer. Mount examples on the peer
as well.

Change-Id: I6dc0a4895dd11c7b87b75b2cb91269deb9839052
Signed-off-by: Srinivasan Muralidharan <muralisr@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2027

Per https://jira.hyperledger.org/browse/FAB-2026

 the proto style in
fabric is inconsistent and violates accepted proto style guidelines.

This CR makes the non-golang code invasive proto changes to conform with
the style guide.

In particular, protoc converts lower_underscore_separated to
LowerUnderscoreSeparated which means that most of our existing fields
can be normalized to the official proto style with no code changes.

This does not fix fields which contained upper case abbreviations
particularly fields ending in 'ID' like txID which must become tx_id and
will be translated to TxId.

This does not fix the enum fields which by proto style should be
UPPER_CASE as this will also require code changes.

Change-Id: Id32d6caba43be9e1c6b1f638be284071bf52f0fd
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

* changes:
  [FAB-2120] Move configtx.Filter back to orderer
  [FAB-2097] Add config next proto

Removing all decorating symbols from logging printouts.

Change-Id: I5d0aac68544df8918cbaacfd78ab3947b562a5ab
Signed-off-by: Artem Barger <bartem@il.ibm.com>

When invoking CLI command the MSP is initialized and logs
stuff to the output, which might be confusing and overly verbose.
This commit simply adjusts the log invocations to be
Debug(f) instead of Info(f).

Change-Id: Id59af04c5733a5314d8b3df068f7fbf51af72251
Signed-off-by: Yacov Manevich <yacovm@il.ibm.com>

Finish the implementation for ledger API GetHistoryForKey().

Lookup the history of key updates by blockNum:tranNum.

For each history record, retrieve the txID and key value
from block storage. This requires passing a block storage handle
into the history query executor, and exposing the block storage
test environment to other packages. Historic txID and key value
is returned to client to enable simple provenance scenarios.

Added tests for GetHistoryForKey() including recovery scenarios.
One test required a fix to block storage syncIndex().
Also tested end-to-end with peer.

Change-Id: I988130e9682f5d8d707c4ec37753bc0e7e297269
Signed-off-by: denyeart <enyeart@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2102



Just as with the orderer shared configuration, having it declared
outside of common was causing problems with imports.  Additionally, in
order to specify a config schema with the pending more flexible config
scheme, this change is necessary.

Change-Id: Ia73e7c06fceb2ab340af7e925796fd1917440643
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2101



It has always been somewhat problematic that orderer config generation
is done in the orderer package, even though other pieces of the system
depend on it.

This CR moves the orderer shared config definitions to the common
package.  This is necessary to define a config schema going forward in
order to lock down the pending more flexible configuration format.

Change-Id: I1b1a4c78eedbc18a90d6838af0829950d6d88e72
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2120



When configtx was moved from orderer to common it brought along the
configtx.Filter, which is inherently an orderer concept and violates the
rule of not importing from common into orderer.

Additionally, this CR moves some of the interfaces into an API
subpackage, to help future refactoring.

Change-Id: If522b44a83ba8d7bc3080c2ce944c927e6621d19
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-2097



Rather than modify the config protos and the config producers, parsing,
and consumers all at once, this CR adds only the new protos, without
removing the old, and makes the minimal changes required only to use the
new proto format while on the wire.

Change-Id: I3fa2b92461a5f1e4418a59d1256c00a2fadcd49a
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-1783. In particular,
"newdeploy.pptx" there.

Move off per channel "on-ledger" deploy model to "on-peer" install
model. This affects version, launch and per channel ledger instatiation.

Now that chaincode is not on ledger but is on-peer, there is no need
to create a container per instance of the chaincode deployed on
different channels. These are the tightly related changes
   . user has to specify version (see, version option in CLI commands)
   . load off file system and not on ledger (see ccprovider.go)
   . chaincode launch separated from chaincode instantiation (see chaincode_support.go)
   . chaincode "init" is no longer tied to deploy (install) (see handler.go)

Note 1 -a minor side effect is that the chaincode container is not killed after instantiate
like it was after the old deploy. It need not be as the chaincode is not bound to a
channel.

Note 2 - the "--peer-chaincodedev=true" has to be treated differently for the
new model. A JIRA https://jira.hyperledger.org/browse/FAB-2128

 has been opened
for this

Change-Id: I34b417d119c16bf296130f8740cddd5af9a8b582
Signed-off-by: Srinivasan Muralidharan <muralisr@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-1926



Adds version to chaincode ID proto specification and uses it in the
installer.

Change-Id: If9f3fa7c6c5661b73a9aacbc2b74a0d2b39adf7f
Signed-off-by: Srinivasan Muralidharan <muralisr@us.ibm.com>

https://jira.hyperledger.org/browse/FAB-1920



peer chaincode install -n <name> -p <path> -v <version>

This command should be executed on the local peer as opposed
to other commands such as "invoke", "query" which are sent to the remote peer.
ie, assumes the chaincode is on the peer (like chaincode_example02). Contrast
this with the old deploy that can be executed from any CLI/SDK outside of the
peer.

On successful execution the command will create a chaincode package on the file
system of the peer prefixed by the "fileSystemPath" as defined in core.yaml.

------- NOTE ------
-The "package" will eventually have more contents such as policy and will be
-signed etc, but for now is just the serialized chaincode deployment spec. This
will be used in subsequent CRs to get the mechanics of a chaincode on multiple
chains ironed out.
------- NOTE ------

Example
=======
With default "fileSystemPath: /var/hyperledger/production",

    peer chaincode install -n mycc -p my/chain/code -v firstversion

will create chaincode package in
    /var/hyperledger/production/chaincodes/mycc.firstversion
using the chaincode defined in my/chain/code.

Change-Id: I479834736d816ed522688dacae6e946340debf11
Signed-off-by: Srinivasan Muralidharan <muralisr@us.ibm.com>

Motivation for this change:
Version is no longer required in the QueryResult structure.
This also keeps the CouchDB layer to be more generic, since the
CouchDB data layer is used by consumers other than Ledger.

- Remove Version from QueryResult struct in couchdb.go

- Previous changes in FAB1818 remove any reference to Version

- Remove 3 instances where Version is populated with development values

Change-Id: I9ac47e96b9530e23f6a31a075e71ba811e13cf05
Signed-off-by: Chris Elder <chris.elder@us.ibm.com>

Fix marbles02 chaincode example delete function.

Change-Id: I80bddc3b7020f748be5df5fd483c8260f11eb706
Signed-off-by: denyeart <enyeart@us.ibm.com>

Change-Id: Iedc4cb64f616adea1f1c4957aedf57429442b66f
Signed-off-by: Greg Haskins <gregory.haskins@gmail.com>

Removed commented out test from gossip_test.go file.

Change-Id: I5e60ccd768974311d9f7b2652020edcf3432650d
Signed-off-by: Gennady Laventman <gennady@il.ibm.com>