GetTransactionByID is used to detect duplicate txids in the ledger. This
function can return an error if there was an I/O problem (and so the duplicate
status of the tx couldn't be properly judged). In that case we must
abort processing on that chain, lest we suffer a state fork.

Change-Id: I32a8ea9c0803f7a38b4c6eb3ea30b4ce1a651456
Signed-off-by: Alessandro Sorniotti <ale.linux@sopit.net>

The ports used by the metrics test (such as 8081 and 8025) are sometimes
bound by other services.  Since the tests never actually connects to the
service, there's no requirement that these ports be specified, only that
they be different, so ephemeral ports are the better choice.

Change-Id: I52f9ddaac0435c50e49dccf64309a132ae933fb7
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

The TestNewGRPCServerInvalidParameters test relies on one of three
particular error strings being returned by the platform to test.  On
some Linux platforms, the error returned is actually none of these
three.  So, this test adds yet another alternative error to this test.

Change-Id: Id6b21daf0943e247456f649998383dadbe140c0e
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

Many of our tests and some of our code are still using order based
initialization for structs.  This is very brittle and against bad
practices.  In an attempt to upgrade the version of protobuf to v1.1.0,
all of files in this changeset broke, because the number of struct
members in the generated code changed.  Although this does not include
any of the proto updates itself, this CR serves as a prerequisite to
doing so.

Change-Id: Ib09ac38735b24894bd413ddaaf59288678c6151d
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

This change set adds a test that demonstrates invalid loading of
an endorsement/validation plugin

Change-Id: I14e782c540ccf116c1766ce84d796bef7beeeadf
Signed-off-by: yacovm <yacovm@il.ibm.com>

When running 'make unit-test' locally using the lastest master,
the peer/chaincode package fails. This is due to TestInstall
relying on chaincode devmode being enabled by another test
instead of explicitly setting it.

Change-Id: If5618846c97b1a0c9b49d9b0901cf3eeeb3289b8
Signed-off-by: Will Lahti <wtlahti@us.ibm.com>

The comments in the go files which are supposed to generate the mockery
mocks are malformed.  They use:

 // go:generate ...

instead of

 //go:generate

They also assume they are being executed from the root directory, rather
than the current directory.  This CR modifies those statements to
correct those errors, regenerates all the mocks, and updates the license
check to ignore mockery style mocks.

Change-Id: I7d8ca47254459e2929286cf614e09893b254d35d
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

Ran scripts/generateHelpDocs.sh
to pull in changes from FAB-10071

Change-Id: I89c3eb929352432d95754cf3c1d84a03f92d8307
Signed-off-by: pama-ibm <pama@ibm.com>

The ACLs function affects how channel config is parsed, and as such, it
must be deterministic across versions.  Channel config parsing should
not allow the presence of ACLs until the corresponding capability has
been enabled.

Change-Id: Ie55a69b620d48198bc485cde820b5f03d6dd6c2d
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

Instead of each test setup having it's own copy
of chaincode we should have a single chaincodei directory containing
chaincode that can be accessed.

Change-Id: I93916f9875f9d8d302d7a42f2488536050614bfb
Signed-off-by: Latitia M. Haskins <latitia.haskins@gmail.com>

Change-Id: I1d0d6c4e578e0d9cfd99a175c112cc728a1df4a6
Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>

This CR adds more UTs and increase the code coverage by UTs
from 72% to 87%

Change-Id: I15d3e692e4449ce80b894fe8da4acfd42073510b
Signed-off-by: manish <manish.sethi@gmail.com>

Presently, the proto translation framework does not understand the new
idemix MSP type.  This CR adds the mapping from type '1' to the idemix
config proto structures.

Change-Id: I0ea4f27d617b4d2c319c4f0f4bdb7d0aef31a3ce
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

This change set makes the MSP protos conform to the official proto style

Change-Id: I766cc341833279fcd4149aeea124978145595fed
Signed-off-by: yacovm <yacovm@il.ibm.com>

Set the correct msp directory for the crypto generated
using idemix

Change-Id: I24798a705c8d11b57ad3cf4a365f0e36b9ffdb4c
Signed-off-by: ratnakar <asara.ratnakar@gmail.com>

Change-Id: I6863621e0f6c9eda47e6d37027f059a4ec3028b6
Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>

...and fix some typos

Change-Id: I81fc5566cbae60349579de861b0fc74237212255
Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>

Small fixes.

Change-Id: Ia9a324500f96118578199d5ced2d01bd0393cbfa
Signed-off-by: joe-alewine <Joe.Alewine@ibm.com>

Minor edits to msp topic

Change-Id: I6fe26a3213274b42d6b621aa684ff07062dac4bf
Signed-off-by: pama-ibm <pama@ibm.com>

Though the anchor peers are not needed for the default e2e
integration test (but for other test such as private data),
as we may use the default configuration as reference and
copy (sometimes), it is better to set the correct port number
for anchor peer as in core.yaml.

Change-Id: Ie48bec21ebfeef27fc7aba2c50fb6c0691edf848
Signed-off-by: senthil <cendhu@gmail.com>

This change set adds cc2cc and collection support to the go client

Change-Id: I4ad1d6627d162e81de77524b809ab59b28395a27
Signed-off-by: yacovm <yacovm@il.ibm.com>