This CR fixes the current behavior of block store index.
In the current implemetation, the indexes that maintain
different pieces of information by txid are overwritten
by a duplicate txid (if any). This CR reverses this behavior
and keeps the first appearance of txid in the index. The future
duplicate txids will not overwrite it.

Though, either of these behaviors (keeping the first tx or
keeping the last tx) are not fully justified, primarily because
the problem itself is a paradox - in the sense that the ids
(that are supposed to be unique by definition) are duplicated.
However, the justification of moving from the current behavior
to the proposed behavior is that, its easy for someone to replay
the transaction or simply use an existing txid in a bogus transaction
just to exploit the current behavior of overwriting the block storage
index and preventing the legitimate user to query about the status
of their transactions.

Change-Id: I3b81ae61c756ef78253b58a94644778716fb0e16
Signed-off-by: manish <manish.sethi@gmail.com>

Addressed Kostas' comments for edits
on the new private data information
in the fabric model topic

Change-Id: I0c943917a7a5380db1b9cc73cee797417e180528
Signed-off-by: pama-ibm <pama@ibm.com>

Updated content to include private
data in the Privacy sections.

Change-Id: I896c875d8b113ad6b4a35513c0ffe89229ac395e
Signed-off-by: pama-ibm <pama@ibm.com>

This CR fixes a bug that in the pvt data purge code
that could leave the orphaned pvt keys un-purged.
See Jira for a more detailed description of the bug.

Also, a number of tests has been added to verify the above bug fix.

Change-Id: I830ec704192977084398d91c29ddb7d364901640
Signed-off-by: manish <manish.sethi@gmail.com>

Current implementation. Formatting.
How to update.

Change-Id: Ic5e14ea562c38144ac754f32f7cf02affe8d183a
Signed-off-by: joe-alewine <Joe.Alewine@ibm.com>

The block-cutter is currently instantiated with a reference to the
orderer channel config.  Once upon a time, each config element was its
own mutable state machine, so this worked fine for v1.0.x.  However, in
v1.1, the individual mutable configs were transformed to be a single
immutable config bundle.  When the config changes, an entirely new
immutable bundle is created and atomically swapped out.

Because of this, the block-cutter only retains the reference to the
initial immutable blob.  It needs to be fixed to pull a fresh reference
of the config through the atomic dereference at every block.  This CR
does just that.

Change-Id: I6be1b65cb8d8cc86d5e47da906a127da6651354e
Signed-off-by: Jason Yellick <jyellick@us.ibm.com>

Improve test coverage on the tests for collection configuration
validation and fix wrong test matchers.

Change-Id: I294c9fb2b8ca570afbca6638fb708e2be86146f3
Signed-off-by: Matthias Neugschwandtner <eug@zurich.ibm.com>

This CR changes the log level for the message in VSCCValidateTxForCC
from INFO to DEBUG to remove the unnecessary noise at the info
level. It also fixes a minor golint issue.

Change-Id: I72d5de621ca04191cc90a8a29a19cb295e021732
Signed-off-by: Will Lahti <wtlahti@us.ibm.com>

Change "start your network:" to "start our network:"
to match previous "We will leverage a script to spin up our network."

Change-Id: Iee98d4119520e326dd8b66c64e3694027c54ffd4
Signed-off-by: Haibo Xi <haibbo@gmail.com>

"Application" is mis-spelled in configtx.rst

Change-Id: I7a9d163f0941b4485c91f3802cde12aa13819927
Signed-off-by: Haibo Xi <haibbo@gmail.com>

Change-Id: I10e49039cfe0fd38087a0ba2fac571f8f5f2d6fb
Signed-off-by: Inbar Badian <Inbar.Badian@ibm.com>

Change-Id: I0cbd1f1f656a4d84f5172b81cb0ebeb4a395d5e6
Signed-off-by: Artem Barger <bartem@il.ibm.com>

Currently while scattering pull request via gossip with digests of
private data, same digest repeating several times and other digests of
missing private data of other transactions from the block just ignored.
This commit fixes scattering procedure to avoid repetitions in same pull
request and also to efficiently retrieve all missing data from one peer
within same request.

Change-Id: If6287b1b04319a9ddc5937c09d0eec4d60f55e2d
Signed-off-by: Artem Barger <bartem@il.ibm.com>

Added:
Collection
Private Data
Please only comment on these two items
in the glossary to stay in the scope of
these changes.

Change-Id: Iadbcc207d9c0820935fe3f123c488320e8805f8b
Signed-off-by: pama-ibm <pama@ibm.com>

This change set adds an extended unit test for discovery, which:
- Uses production implementations of all discovery components, including
  the discovery support objects found under discovery/
- Uses production implementations of MSPs and real x509 identities
- Uses a real genesis block from configtxgen for config query testing
- Uses a mock gossip implementation
- Uses a mock ledger implementation, but a production lifecycle
  support (the object that intermediates between discovery and the ledger
  and is found under core/cclifecycle
- Uses real gRPC servers and clients with TLS.
  The gRPC servers listen to ephemeral ports, so we won't get
  a bind: already in use error in CI ;)

The test contains the following tests:

TestGreenPath: Tests all query types, specifically:
- cc2cc endorsers query and endorsers query with collections
- both channel and local peer query
- config query

TestRevocation:
- Queries once to warmup the cache
- Queries twice to ensure the underlying MSP isn't used
  because the ACL cache takes the hit
- Advances the config sequence and artificially revokes
  all identities in the MSP manager
- Queries thrice and sees that the cache isn't hit,
  and that "access denied" is returned

TestEndorsementComputationFailure:
- tests a case where the collection policy doesn't cover
  any possible principal set combination for endorsement

TestLedgerFailure:
- Tests that querying from the ledger fails in some of the keys

Change-Id: I717572e04c8f178ef10bd3807f707cf58da0b406
Signed-off-by: yacovm <yacovm@il.ibm.com>

Change-Id: I04061ef33459d962e3778545b908f6bc3e4b0ac8
Signed-off-by: yacovm <yacovm@il.ibm.com>

An update channel call was being performed with each
QueryInvoke when using the RunQueryInvokeQuery func.
This CR fixes that error.

Change-Id: I9d2a9b0228bafcdc20cb9de43831ce5d75bdbd4d
Signed-off-by: Latitia M Haskins <latitia.haskins@gmail.com>

This CR adds support for a pvtdata store that has
pvt data from both v1.1 and v1.2. See jira for
more details

Change-Id: Icecc8ee085a097c439e205736759785b17818348
Signed-off-by: manish <manish.sethi@gmail.com>